-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
regr_test.py
: improve interaction between --all
and --quiet
flags
#9349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It works as expected. |
And we have a failing mypy run as well: https://github.com/python/typeshed/actions/runs/3665455929/jobs/6196543252 (Though it looks like I could probably sink a little more work into improving that traceback) |
Is the reason the failure shows up ~16 times that we run mypy in a matrix (Python version, OS) and report the failure every time? |
Yup! Just pushed a commit to this PR branch that hopefully clarifies things a bit? The issue was that the new |
Nice, feel free to hijack this PR for your change, or just open a new PR. A more radical change could be to show only the first failure if there are multiple identical ones. After all, in most cases test cases are going to fail in the same way on multiple runs. |
This is true, but it won't always be the case. I feel like this solution is ~good enough for now. I'm gonna commence hijacking ;) |
regr_test.py
: improve interaction between --all
and --quiet
flags
cf. #9348 cc @jab