-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add stubs for pyasn1
#9437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stubs for pyasn1
#9437
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
It looks like you removed a lot of In general, we don't include methods or attributes in a subclass if they have the same signature as the same method or attribute as the superclass. But In general, we need to be a lot more careful with dunder methods when it comes to removing them just because they're redundant overrides. E.g. python/mypy#13800 was caused by removing a few |
Oh 😯 No problem I'll add 'em back! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
For use with
ldap3
andpython-jose
stubs 😃Source: https://github.com/pyasn1/pyasn1/tree/db8f1a7930c6b5826357646746337dafc983f953/pyasn1
Ref: #9491