-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Use pyasn1 in ldap3 #9470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pyasn1 in ldap3 #9470
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…into pyasn1-in-ldap3
This comment has been minimized.
This comment has been minimized.
I had the same 2 errors locally. This really looks like a stubtest bug: https://github.com/python/typeshed/actions/runs/3866310116/jobs/6590353764#step:5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I've left 3 comments on the first file. It looks like those comments also apply to a lot of the other touched files, so I'll let you respond to those comments before doing a further review :)
Yeah, I can't say I really understand what's going on here. The runtime source code is a bit of a maze, but even if it's doing something extremely dynamic that stubtest can't understand, the fact that stubtest is magicking line numbers out of thin air is a bit strange. Don't know if @hauntsaninja has any theories? Anyway, for now I guess you should probably just allowlist them :) |
The bug is just the line number? If so, why does it need an allowlist entry? stubtest's logic for line numbers is a little hacky, looks like it's just the line number from the file that the parent class is in (pyasn1.type.univ) |
This comment has been minimized.
This comment has been minimized.
I couldn't find the right type from source. But I got it now |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A few more things, but nearly there!
…into pyasn1-in-ldap3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Gonna have to wait for stub-uploader to push
types-pyasn1
first.Dependant on #9471Closes #9471
Fixes a lot of Any subtyping issues.
Ref: #9491