-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Fix Any subclassing in SQLAlchemy
#9492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
How much of an "alternative" is |
This comment has been minimized.
This comment has been minimized.
Hmm, I'd prefer us to find another solution here :/ It feels really weird for us to declare a dependency on mypy so that we can provide accurate stubs for a directory that only exists to provide a mypy plugin for a completely separate set of SQLAlchemy stubs. |
Come to think of it, weird that mypy_test can't find mypy. We shouldn't need to depend on it at all. I guess it's because of the virtual environment being created. This should be better now :) |
SQLAlchemy
This comment has been minimized.
This comment has been minimized.
Just as a discussion point. Since SQLAlchemy 2.0 is typed. And sqlalchemy2-stubs is actively being developed for 1.4 by the same organization (replacing dropbox's sqlalchemy-stub). And we can now reference external stubs. |
sqlalchemy2-stubs has some shortcomings, mostly around the fact that it requires a mypy plugin. I had some more plans with our stubs, but we will most likely drop the stubs some point after SQLAlchemy 2 comes out, whenever that is. That said, I'm opposed to depend on sqlalchemy2-stubs. |
@srittau, do you think we actually need the |
@AlexWaygood Sure. I think we have too many internal modules in our stubs anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Gotta love fixing things by just removing code ! |
Fixed a bug by removing the feature ;) |
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Fixes 10 Any subclassing issues:
_AsyncIoGreenlet
wich, looking at source code and from the name of the class and module, seems to be implementation detailsRef: #9491, #9493