Update comments post #5768 #9527
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Let's leave the pycocotools comments as they are for now. It's a shortcoming of the logic in the stub_uploader (#9518 (comment)), and I'd like to try fixing that shortcoming :)
The other changes look great!
Ahh! (Read the comment you left on the pycocotools pr too). Alright I'll undo that comment since it may be fixed separately (and doesn't accurately describe the issue anyway) |
|
The only one I didn't make a PR for is |
| @@ -264,7 +264,7 @@ def run_mypy( | |||
| # Stub completion is checked by pyright (--allow-*-defs) | |||
| "--allow-untyped-defs", | |||
| "--allow-incomplete-defs", | |||
| "--allow-subclassing-any", # TODO: Do we still need this now that non-types dependencies are allowed? (#5768) | |||
| "--allow-subclassing-any", # See #9491 | |||
There was a problem hiding this comment.
If #9491 is accepted, then this line will be removed. If not then this links to the discussion/decision.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Now that #5768 is closed and completed. Comments mentioning the inability to use certain imports due to the types dependency restriction are no longer true. However, some still can't be installed for a different reason: The dependency isn't declared by the original package. So the stub_uploader refuses it.
I looked for mentions of
numpy,comtypesand 5768. If you know more that I missed, please let me know.