Skip to content

[stubsabot] Mark SQLAlchemy as obsolete since 2.0.0 #9595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 27, 2023

@JelleZijlstra
Copy link
Member

We should probably not treat prereleases as obsoleting our stubs. Let's wait for 2.0.0 final.

@hauntsaninja
Copy link
Collaborator

PR to stubsabot welcome!

@Avasam
Copy link
Collaborator

Avasam commented Jan 27, 2023

On a sidenote, I'd like to be able to get the stubs at least on par with https://github.com/microsoft/python-type-stubs/tree/main/sqlalchemy (used by Pylance) so it can be dropped from there. Also reducing the confusingly high number of source of truths for SQLAlchemy stubs.
Then see how close together I can make types-sqlalchemy (no mypy plugin) and sqlalchemy2-stubs (uses mypy plugin). A lot of users (myself included) won't be able to immediately upgrade to 2.0 anyway.

Other question, is it possible to specify <2.0.0 in METADATA.toml ? We already know 2.0 will come typed and typeshed's stubs shouldn't be used with it. So I don't see any harm in at least doing that if possible.

@Avasam
Copy link
Collaborator

Avasam commented Jan 27, 2023

We should probably not treat prereleases as obsoleting our stubs. Let's wait for 2.0.0 final.

I think 2.0 just got out today and that's what stubsabot caught. But also says that it's technically been obsolete since the first beta (oldest py.typed version), which is also true.

@AlexWaygood
Copy link
Member

On a sidenote, I'd like to be able to get the stubs at least on par with https://github.com/microsoft/python-type-stubs/tree/main/sqlalchemy (used by Pylance) so it can be dropped from there. Also reducing the confusingly high number of source of truths for SQLAlchemy stubs. Then see how close together I can make types-sqlalchemy (no mypy plugin) and sqlalchemy2-stubs (uses mypy plugin). A lot of users (myself included) won't be able to immediately upgrade to 2.0 anyway.

Other question, is it possible to specify <2.0.0 in METADATA.toml ? We already know 2.0 will come typed and typeshed's stubs shouldn't be used with it. So I don't see any harm in at least doing that if possible.

FWIW, marking the stubs as officially obsolete doesn't preclude us from making improvements to the stubs -- we can still make changes until they're deleted from typeshed. And we're also under no obligation to delete the stubs immediately after they've been marked obsolete for 6 months (though we almost certainly should if the maintainers ask us to).

@github-actions github-actions bot changed the title [stubsabot] Mark SQLAlchemy as obsolete since 2.0.0b1 [stubsabot] Mark SQLAlchemy as obsolete since 2.0.0 Jan 29, 2023
@AlexWaygood AlexWaygood marked this pull request as ready for review January 29, 2023 00:13
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to merge this now that the first-release-with-py.typed thing has been corrected. It doesn't stop us from making improvements to our SQLAlchemy stubs in the intervening period before we remove them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants