-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[stubsabot] Mark SQLAlchemy as obsolete since 2.0.0 #9595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We should probably not treat prereleases as obsoleting our stubs. Let's wait for 2.0.0 final. |
PR to stubsabot welcome! |
On a sidenote, I'd like to be able to get the stubs at least on par with https://github.com/microsoft/python-type-stubs/tree/main/sqlalchemy (used by Pylance) so it can be dropped from there. Also reducing the confusingly high number of source of truths for SQLAlchemy stubs. Other question, is it possible to specify |
I think 2.0 just got out today and that's what stubsabot caught. But also says that it's technically been obsolete since the first beta (oldest |
FWIW, marking the stubs as officially obsolete doesn't preclude us from making improvements to the stubs -- we can still make changes until they're deleted from typeshed. And we're also under no obligation to delete the stubs immediately after they've been marked obsolete for 6 months (though we almost certainly should if the maintainers ask us to). |
0778cb0
to
3ac3c8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to merge this now that the first-release-with-py.typed
thing has been corrected. It doesn't stop us from making improvements to our SQLAlchemy
stubs in the intervening period before we remove them.
Release: https://pypi.org/pypi/SQLAlchemy/2.0.0
Homepage: https://www.sqlalchemy.org