Add more defaults to the stdlib #9606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
JelleZijlstra
approved these changes
Jan 29, 2023
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Avasam
pushed a commit
to Avasam/typeshed
that referenced
this pull request
Feb 1, 2023
Continuing work towards python#8988. The first five commits were created using stubdefaulter on various Python versions; the following commits were all created manually by me to fix various problems. The main things this adds that weren't present in python#9501 are: - Defaults in Windows-only modules and Windows-only branches (because I'm running a Windows machine) - Defaults in non-py311 branches - Defaults for float parameters - Defaults for overloads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing work towards #8988.
The first five commits were created using
stubdefaulteron various Python versions; the subsequent commits were all created manually by me to fix various problems. The main things this adds that weren't present in #9501 are:floatparametersTo test this PR, I've run mypy-master stubtest locally on Python 3.7, Python 3.8, Python 3.9, Python 3.10 and Python 3.11. I also temporarily switched to using mypy-master stubtest in CI in ec4471f so that we could see the results.