-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[DO-NOT-MERGE] Checking to see if pyright verifies third-party test cases against false negatives correctly #9623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… false negatives correctly
Anybody have any ideas how to get pyright to emit an error on the unused |
Weird, locally on main: |
Maybe it's something specific to do with how pyright-action invokes pyright |
It's the same if I call pyright directly: |
Ok, the ** path just isn't working
Edit 2: What I saw from 1.1.283 is unrelated. |
Amazing, thanks for the investigation! I'll be AFK for a few hours, but I'll see about filing a bug report to pyright later if you don't beat me to it ;) |
Nvm the bisect part, I celebrated too early and didn't realize the errors I was getting were from a different file. :/ But what I said about using the direct path working is still true. So if it's broken, it's been broken since forever. I've open an issue with a minimal reproduction: microsoft/pyright#4553 |
A fix has been released! https://github.com/microsoft/pyright/releases/tag/1.1.292 |
Brilliant. I opened #9646 for the pyright bump. |
Closing in favour of #9650 |
If our test-case setup is working correctly, pyright should error out with a complaint about an unused
type: ignore
comment.