Add get_origin annotations #9811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
AlexWaygood
reviewed
Feb 24, 2023
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
reviewed
Feb 24, 2023
This comment has been minimized.
This comment has been minimized.
…peshed into add-get-origin-annotations
AlexWaygood
reviewed
Feb 24, 2023
…peshed into add-get-origin-annotations
…peshed into add-get-origin-annotations
|
I should've used pre-commit here all along but I guess it's lesson learned. |
No worries at all! The reason we have autofixes turned on in CI is so that people don't have use pre-commit locally :) |
AlexWaygood
reviewed
Feb 24, 2023
stdlib/typing_extensions.pyi
Outdated
Comment on lines
165
to
166
| @overload | ||
| def get_origin(tp: ParamSpecArgs | ParamSpecKwargs) -> ParamSpec: ... |
There was a problem hiding this comment.
Oh, actually, this overload can work on 3.7+ for typing_extensions (but not for typing, where ParamSpecs only exist on 3.10+):
(py37) C:\Users\alexw\coding\typeshed>python
Python 3.7.16 (default, Jan 17 2023, 16:06:28) [MSC v.1916 64 bit (AMD64)] :: Anaconda, Inc. on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> from typing_extensions import ParamSpec, get_origin
>>> type(get_origin(ParamSpec("P").args))
<class 'typing_extensions.ParamSpec'>There was a problem hiding this comment.
Will take care of it later today. Thanks!
AlexWaygood
reviewed
Feb 24, 2023
This comment has been minimized.
This comment has been minimized.
AlexWaygood
approved these changes
Feb 25, 2023
This comment has been minimized.
This comment has been minimized.
|
Diff from mypy_primer, showing the effect of this PR on open source code: pydantic (https://github.com/samuelcolvin/pydantic)
+ pydantic/_internal/_generate_schema.py:377: error: Unused "type: ignore" comment
hydra-zen (https://github.com/mit-ll-responsible-ai/hydra-zen)
+ src/hydra_zen/structured_configs/_utils.py:69: error: Name "get_origin" already defined (possibly by an import) [no-redef]
- src/hydra_zen/structured_configs/_utils.py:69: error: All conditional function variants must have identical signatures [misc]
- src/hydra_zen/structured_configs/_utils.py:69: note: Original:
- src/hydra_zen/structured_configs/_utils.py:69: note: def get_origin(tp: Any) -> Optional[Any]
- src/hydra_zen/structured_configs/_utils.py:69: note: Redefinition:
- src/hydra_zen/structured_configs/_utils.py:69: note: def get_origin(tp: Any) -> Optional[type]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
When you know for a fact that you are using get_origin on a GenericAlias, your type checker will show you errors about the result being
Any | None. These type hints attempt to fix this issue at least for the most common use cases. I tried handling every overload that was possible to handle but if you have any suggestions -- please, share them :)CI seems to be broken because not every import is available in earlier versions. Am thinking on how to handle it right now.