Skip to content

distutils/setuptools: Don't use wildcards for allowlist entries #9900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2023
Merged

distutils/setuptools: Don't use wildcards for allowlist entries #9900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion stubs/setuptools/@tests/stubtest_allowlist.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,27 @@ pkg_resources.EggMetadata.loader
setuptools._distutils.dist.Distribution.get_command_obj

# Dynamically created in __init__
setuptools._distutils.dist.Distribution.get_.*
setuptools._distutils.dist.Distribution.get_name
setuptools._distutils.dist.Distribution.get_version
setuptools._distutils.dist.Distribution.get_fullname
setuptools._distutils.dist.Distribution.get_author
setuptools._distutils.dist.Distribution.get_author_email
setuptools._distutils.dist.Distribution.get_maintainer
setuptools._distutils.dist.Distribution.get_maintainer_email
setuptools._distutils.dist.Distribution.get_contact
setuptools._distutils.dist.Distribution.get_contact_email
setuptools._distutils.dist.Distribution.get_url
setuptools._distutils.dist.Distribution.get_license
setuptools._distutils.dist.Distribution.get_licence
setuptools._distutils.dist.Distribution.get_description
setuptools._distutils.dist.Distribution.get_long_description
setuptools._distutils.dist.Distribution.get_keywords
setuptools._distutils.dist.Distribution.get_platforms
setuptools._distutils.dist.Distribution.get_classifiers
setuptools._distutils.dist.Distribution.get_download_url
setuptools._distutils.dist.Distribution.get_requires
setuptools._distutils.dist.Distribution.get_provides
setuptools._distutils.dist.Distribution.get_obsoletes

# Uncomment once ignore_missing_stub is turned off
# # Not supported by typeshed
Expand Down
23 changes: 21 additions & 2 deletions tests/stubtest_allowlists/py3_common.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,8 +523,27 @@ xml.etree
xml.sax

# Dynamically created
distutils.dist.Distribution.get_.*
distutils.core.Distribution.get_.*
distutils.(dist|core).Distribution.get_name
distutils.(dist|core).Distribution.get_version
distutils.(dist|core).Distribution.get_fullname
distutils.(dist|core).Distribution.get_author
distutils.(dist|core).Distribution.get_author_email
distutils.(dist|core).Distribution.get_maintainer
distutils.(dist|core).Distribution.get_maintainer_email
distutils.(dist|core).Distribution.get_contact
distutils.(dist|core).Distribution.get_contact_email
distutils.(dist|core).Distribution.get_url
distutils.(dist|core).Distribution.get_license
distutils.(dist|core).Distribution.get_licence
distutils.(dist|core).Distribution.get_description
distutils.(dist|core).Distribution.get_long_description
distutils.(dist|core).Distribution.get_keywords
distutils.(dist|core).Distribution.get_platforms
distutils.(dist|core).Distribution.get_classifiers
distutils.(dist|core).Distribution.get_download_url
distutils.(dist|core).Distribution.get_requires
distutils.(dist|core).Distribution.get_provides
distutils.(dist|core).Distribution.get_obsoletes

# Platform differences that cannot be captured by the type system
os.O_[A-Z_]+
Expand Down