Skip to content

Remove useless overloads from sys.getsizeof #9987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2023
Merged

Remove useless overloads from sys.getsizeof #9987

merged 2 commits into from
Mar 30, 2023

Conversation

sobolevn
Copy link
Member

There's no need to use @overload, because signature is simple enough.

Btw, I am preparing a PR to CPython to convert this function to AC, so __text_signature__ will be available :)

srittau
srittau approved these changes Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this doesn't really have a default value, so ... is fine here.

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood AlexWaygood merged commit 619125b into main Mar 30, 2023
@AlexWaygood AlexWaygood deleted the simplify-sys-getsizeof branch March 30, 2023 12:23
@sobolevn sobolevn mentioned this pull request Mar 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolevn @srittau @AlexWaygood