Skip to content

Fix assignability rule for typed dictionaries #1974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

Fix assignability rule for typed dictionaries #1974

merged 1 commit into from
Apr 17, 2025

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Apr 17, 2025

Fixes #1973.

@Viicos Viicos mentioned this pull request Apr 17, 2025
Closed
JelleZijlstra
JelleZijlstra approved these changes Apr 17, 2025
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I don't think this needs the full Typing Council approval process because it fixes what is essentially a typo.

@erictraut erictraut merged commit 0b9fed8 into python:main Apr 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in TypedDict assignability rule
3 participants
@Viicos @JelleZijlstra @erictraut