Code

Refactor Union, Tuple, and Callable#308

Code

Merged

gvanrossum merged 39 commits intopython:masterpython/typing:masterfrom

ilevkivskyi:the-big-syncilevkivskyi/typehinting:the-big-syncCopy head branch name to clipboard

Oct 29, 2016

Commits

Commits on Oct 23, 2016

• Make Tuple[T, S] subcriptable and subclassable

  ilevkivskyi

  committed
  e8c3ad6

  Copy full SHA for e8c3ad6

• Make Callable[..., T] subscriptable and subclassable

  ilevkivskyi

  committed
  cfcf81f

  Copy full SHA for cfcf81f

• Make Union[T, S] subsctiptable

  ilevkivskyi

  committed
  1368e97

  Copy full SHA for 1368e97

• Disable plain Union and Optional as type arguments

  ilevkivskyi

  committed
  7ee4a1a

  Copy full SHA for 7ee4a1a

• Implement __eq__ for GenericMeta

  ilevkivskyi

  committed
  5fdceba

  Copy full SHA for 5fdceba

• Implement __eq__ for Unions

  ilevkivskyi

  committed
  f339586

  Copy full SHA for f339586

• Refactor common code in __eq__ and __repr__

  ilevkivskyi

  committed
  26f50a3

  Copy full SHA for 26f50a3

• Remove redundant code

  ilevkivskyi

  committed
  65de907

  Copy full SHA for 65de907

• Fix minor bugs + mini-refactoring

  ilevkivskyi

  committed
  897de4e

  Copy full SHA for 897de4e

• Fix repr of Callable subclasses

  ilevkivskyi

  committed
  c687ffa

  Copy full SHA for c687ffa

• Don't be too pedantic in GenericMeta._eval_type

  ilevkivskyi

  committed
  582a37f

  Copy full SHA for 582a37f

• Simplify __hash__ and factor out orig_chain

  ilevkivskyi

  committed
  02e6b14

  Copy full SHA for 02e6b14

• Remove outdated tests + be more pedanctic in _Union._eval_type

  ilevkivskyi

  committed
  8d802cc

  Copy full SHA for 8d802cc

• Add tests

  ilevkivskyi

  committed
  4e2527c

  Copy full SHA for 4e2527c

Commits on Oct 24, 2016

• Factor out _subs_tree for Union and Generic

  ilevkivskyi

  committed
  92da67f

  Copy full SHA for 92da67f

• Prohibit plain Generic[T] as type argument

  ilevkivskyi

  committed
  7563c92

  Copy full SHA for 7563c92

• Correct a comment

  ilevkivskyi

  committed
  f33545b

  Copy full SHA for f33545b

• Erase but preserve type also for Callable

  ilevkivskyi

  committed
  4a996b2

  Copy full SHA for 4a996b2

• Erase but preserve type for all generics

  ilevkivskyi

  committed
  6564742

  Copy full SHA for 6564742

• Restore original __next_in_mro__ and use more precise bases

  

  Ivan Levkivskyi

  committed
  184f089

  Copy full SHA for 184f089

• Preserve __qualname__ on subscription

  

  Ivan Levkivskyi

  committed
  b613325

  Copy full SHA for b613325

• Add tests and factor common stuff for Union

  ilevkivskyi

  committed
  011b9d8

  Copy full SHA for 011b9d8

• Add even more tests

  ilevkivskyi

  committed
  52712a6

  Copy full SHA for 52712a6

• One more test + minor code simplification

  ilevkivskyi

  committed
  2641151

  Copy full SHA for 2641151

Commits on Oct 25, 2016

• Polishing code

  ilevkivskyi

  committed
  9f1fb98

  Copy full SHA for 9f1fb98

• Minor changes

  ilevkivskyi

  committed
  279a67e

  Copy full SHA for 279a67e

• Precalculate hash + refactor + more tests

  ilevkivskyi

  committed
  f173fde

  Copy full SHA for f173fde

• Simplify repr for Union

  ilevkivskyi

  committed
  819d472

  Copy full SHA for 819d472

• Add big test for __eq__, __repr__, and Any substitution

  ilevkivskyi

  committed
  e6f19a8

  Copy full SHA for e6f19a8

• Add test to illustrate substitution

  ilevkivskyi

  committed
  deed806

  Copy full SHA for deed806

• Minor change in tests

  ilevkivskyi

  committed
  f6382a7

  Copy full SHA for f6382a7

• Add/expand comments and docstrings

  ilevkivskyi

  committed
  9bc7374

  Copy full SHA for 9bc7374

• Fix the __qualname__ in PY 3.2

  ilevkivskyi

  committed
  c2724ce

  Copy full SHA for c2724ce

• Add tests to Python 2

  ilevkivskyi

  committed
  fd3e344

  Copy full SHA for fd3e344

• Modify Union in Python 2

  ilevkivskyi

  committed
  cd7bbe2

  Copy full SHA for cd7bbe2

• Update Python 2 tests

  ilevkivskyi

  committed
  068ab5e

  Copy full SHA for 068ab5e

• Change remaining parts in Python 2

  ilevkivskyi

  committed
  09c4797

  Copy full SHA for 09c4797

• Fix final test in PY 2

  ilevkivskyi

  committed
  60303f7

  Copy full SHA for 60303f7

Commits on Oct 26, 2016

• Also call super().__init__ in PY 2 Generic

  ilevkivskyi

  committed
  ea5dd05

  Copy full SHA for ea5dd05