Add PEP 613 TypeAlias to typing_extensions #732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
reviewed
Jun 11, 2020
|
|
||
| Predicate = Callable[[...], bool] # type: TypeAlias | ||
|
|
||
| It's invalid when used anyhow but as in the example above. |
There was a problem hiding this comment.
anyhow but -> anywhere except
|
|
||
| Predicate: TypeAlias = Callable[[...], bool] | ||
|
|
||
| It's invalid when used anyhow but as in the example above. |
There was a problem hiding this comment.
anyhow as -> anywhere except
|
|
||
| Predicate: TypeAlias = Callable[[...], bool] | ||
|
|
||
| It's invalid when used anyhow but as in the example above. |
|
|
||
| Predicate: TypeAlias = Callable[[...], bool] | ||
|
|
||
| It's invalid when used anyhow but as in the example above. |
|
Oh, sorry, I missed the notifications. I've added positive tests and fixed docstrings as suggested. Also, there happened to be a mistake in I pushed everything as individual commits to make the changes more evident as e.g. typeshed contributing guidelines require, let me know if I need to squash them manually. |
|
@east825 Please don't squash, we do that when we merge. I am behind on code reviews, ping me later this week. |
east825
added a commit
to east825/typeshed
that referenced
this pull request
Jun 19, 2020
At the moment this special marker annotation described in PEP 613 exists only in typing_extensions module (see python/typing#732).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.