Skip to content

Fix typing_extensions tests for 3.10a3 #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2021
Merged

Fix typing_extensions tests for 3.10a3 #773

merged 1 commit into from
Jan 2, 2021

Conversation

Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented Jan 2, 2021 •
edited
Loading

Runtime checks for user-defined Generics were loosened to allow PEP 612 in 3.10 latest (tentatively Python 3.10a3), so some tests which expect TypeError are now failing. This ignores them for Python 3.10 and above.

Sample test failure output:

======================================================================
FAIL: test_defining_generic_protocols_old_style (__main__.ProtocolTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_typing_extensions.py", line 1244, in test_defining_generic_protocols_old_style
    PR[int, 1]
AssertionError: TypeError not raised

----------------------------------------------------------------------

@Fidget-Spinner Fidget-Spinner changed the title Fix tests for 3.10a3 Fix typing_extensions tests for 3.10a3 Jan 2, 2021
@gvanrossum gvanrossum merged commit c7a981a into python:master Jan 2, 2021
@Fidget-Spinner Fidget-Spinner deleted the fix-3.10 branch January 2, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fidget-Spinner @gvanrossum @the-knights-who-say-ni