Vendor typing._SpecialForm to fool typing._type_check #966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has severe merge conflicts because we just renamed src_py3 to src, could you rebase? |
|
:) I was looking into that. |
Adds a local copy of _SpecialForm in our namespace, so typing._type_check won't raise TypeError. (#964)
e07c767 to
936ebbe
Compare
Gobot1234
reviewed
Nov 26, 2021
Co-authored-by: James Hilton-Balfe <50501825+Gobot1234@users.noreply.github.com>
| @@ -2048,40 +2048,61 @@ def __eq__(self, other): | |||
|
|
|||
| TypeGuard = _TypeGuard(_root=True) | |||
|
|
|||
| if not hasattr(typing, "Self") and sys.version_info[:2] >= (3, 7): | |||
| # Vendored from cpython typing._SpecialFrom | |||
There was a problem hiding this comment.
It's a bit hard to follow the if chains here, but can't this just be together with the appropriate branch for 3.7-3.10 so we don't have to duplicate the conditions?
There was a problem hiding this comment.
Should I refactor the uses of typing._SpecialForm to use this vendored verion too?
There was a problem hiding this comment.
Let's change Self only for simplicity.
JelleZijlstra
approved these changes
Nov 29, 2021
srittau
pushed a commit
to srittau/typing
that referenced
this pull request
Dec 2, 2021
Adds a local copy of _SpecialForm in our namespace, so typing._type_check won't raise TypeError. (#964) Co-authored-by: James Hilton-Balfe <50501825+Gobot1234@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a local copy of _SpecialForm in our namespace, so
typing._type_check won't raise TypeError. (#964)