Skip to content

Remove unnecessary hasattr check from TypedDict #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 22, 2025
Merged

Remove unnecessary hasattr check from TypedDict #533

merged 4 commits into from
Feb 22, 2025

Conversation

Daraan
Copy link
Contributor

@Daraan Daraan commented Feb 22, 2025

Adding @JelleZijlstra's PR python/cpython#109544

Including related additional tests from me python/cpython#130460 - not yet merged, hope that's fine.

@Daraan Daraan marked this pull request as draft February 22, 2025 17:12
Daraan and others added 2 commits February 22, 2025 18:19
@Daraan @JelleZijlstra
Backport of python/cpython#109544
e87e79d 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@Daraan
backport of python/cpython#130460
e2abebf
@Daraan Daraan force-pushed the TypedDict/backport__total__ branch from a3474f9 to e2abebf Compare February 22, 2025 17:20
@Daraan Daraan marked this pull request as ready for review February 22, 2025 17:21
@Daraan Daraan mentioned this pull request Feb 22, 2025
Merged
JelleZijlstra
JelleZijlstra approved these changes Feb 22, 2025
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, would you mind adding a changelog entry since this does change user-visible behavior in an edge case?

@JelleZijlstra JelleZijlstra merged commit 3f47bf9 into python:main Feb 22, 2025
23 checks passed
@Daraan Daraan deleted the TypedDict/backport__total__ branch February 22, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Daraan @JelleZijlstra