Move CI to "ubuntu-latest" (round 2) #570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub is decommissioning Ubuntu 20.04. I wouldn't expect our tests to have a lot of OS version dependencies, so let's try just running ubuntu-latest everywhere.
This is not strictly required for the current workflow to work so might as well keep the status quo
| @@ -38,12 +38,10 @@ jobs: | |||
| # For available versions, see: | |||
| # https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json | |||
| python-version: | |||
| - "3.8" | |||
There was a problem hiding this comment.
Let's keep 3.8 (not 3.8.0) for now, we still want to test 3.8 for the upcoming bugfix release, and it seems to work on 22.04.
There was a problem hiding this comment.
Sounds good - do we want to also include any earlier version that 22.04 supports?
There was a problem hiding this comment.
Feels not worth it, the testing on point releases is a bit of a spotcheck anyway. Thanks!
JelleZijlstra
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picks up from #567