Skip to content

fix TypeAliasType union with typing.TypeAliasType #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 4, 2025
Merged

fix TypeAliasType union with typing.TypeAliasType #575

merged 2 commits into from
Apr 4, 2025

Conversation

jorenham
Copy link
Contributor

@jorenham jorenham commented Apr 3, 2025

closes #574

JelleZijlstra
JelleZijlstra reviewed Apr 4, 2025
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you add a changelog entry too?

JelleZijlstra
JelleZijlstra reviewed Apr 4, 2025
View reviewed changes
@JelleZijlstra JelleZijlstra merged commit 8092c39 into python:main Apr 4, 2025
22 checks passed
@jorenham jorenham deleted the fix-574 branch April 4, 2025 14:00
@jorenham
Copy link
Contributor Author

jorenham commented Apr 4, 2025

Thanks Jelle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeAliasType raises TypeError when union'd with typing.TypeAliasType
2 participants
@jorenham @JelleZijlstra