-
-
Notifications
You must be signed in to change notification settings - Fork 118
Drop support for Python 3.8 #585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Not sure if anything should be done here? typing_extensions/src/typing_extensions.py Lines 1337 to 1341 in 4525e9d
cc @Daraan |
3.9 introduced def _could_be_inserted_optional(t):
"""detects Union[..., None] pattern"""
- # 3.8+ compatible checking before _UnionGenericAlias
- if get_origin(t) is not Union:
+ if not isinstance(t, typing._UnionGenericAlias):
return False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this overall looks great! I have a smattering of nits and a couple of substantive comments:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #568.