Skip to content

DOC: add missing versionadded metadata for TypeAlias #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

neutrinoceros
Copy link
Contributor

According to git blame, TypeAlias was added in d362ccb, which GitHub's UI indicates was included as early as 3.10.0.0

@JelleZijlstra
Copy link
Member

We didn't track version changes before 4.0 very well. There are many other objects added before 4.0 that also don't have a versionadded note, so I'd rather not add it for just one of them.

4.0 is almost four years old at this point so I don't see much point in tracking down exactly when in the 3.* series each object was added.

@neutrinoceros
Copy link
Contributor Author

I see. The reason I opened this is that I only needed this single feature and wanted to define my dependency on typing-extension in the loosest (yet correct) way, so I went to search this specific bit of information and added it back when I got it. I understand if only doing this (very) partially isn't desired. However, I would suggest adding a note somewhere saying that whenever this information is missing, 4.0.0 is a safe minimum requirement to assume, because this isn't obvious at all from the outside.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants