Fix py27 vs2015 build and add patch mgmt #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 1, 2017
jcfr
commented
Aug 1, 2017
README.rst
Outdated
| @@ -61,6 +61,12 @@ options on the commandline with `-DOPTION=VALUE`, or use the "ccmake" gui. | |||
| PYTHON_VERSION=major.minor.patch (defaults to 3.5.2) | |||
| The version of Python to build. | |||
|
|
|||
| PYTHON_APPLY_PATCHES=ON|OFF (defaults to OFF) | |||
There was a problem hiding this comment.
I will fix this. Default is ON
|
@dzenanz @adamrankin Thanks to your outstanding investigative work, we were able to put together a collection of patches. These patches are directly managed by |
Thanks: Adam Rankin <arankin@robarts.ca> Thanks: Dzenan Zukic <dzenan.zukic@kitware.com> Thanks: Franklin King <franklin.king@queensu.ca>
14b8e1a to
18176d6
Compare
|
Cc: @msmolens |
jcfr
referenced
this pull request
in Tech-XCorp/pythoncm
Aug 1, 2017
|
Merging. VS2013 and VS2015 builds are successful, all linux build are successful, only osx is lagging behind. |
msmolens
reviewed
Aug 2, 2017
| option(PYTHON_APPLY_PATCHES "Apply patches" ON) | ||
| if(PYTHON_APPLY_PATCHES) | ||
| include(cmake/PythonApplyPatches.cmake) | ||
| endif() |
There was a problem hiding this comment.
Because PythonApplyPatches.cmake uses PY_VERSION, this block should come after the block below that extracts the version from the source.
jwcotejr
added a commit
to nirai-compiler/python
that referenced
this pull request
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.