Add support for Python 3.10 #345
Closed
+177
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gongminmin
added a commit
to gongminmin/python-cmake-buildsystem
that referenced
this pull request
Jan 19, 2024
bjia56
added a commit
to bjia56/portable-python-cmake-buildsystem
that referenced
this pull request
Mar 13, 2024
* Add support for Python 3.10 Based on python-cmake-buildsystem/python-cmake-buildsystem#345 * Add limited Python 3.11 support * add 3.11.7 * test 3.11 * modify sources for 3.11 * fix cache.c * install new tcl-tk * newer macos * skip tkinter on macos * fix condition * allow verbose CI builds * back to macos-latest * syntax * control tkinter outside * tweak gha expression * add verbose make * adjust ndbm detection * add HAVE_NETDB_H * use c11 * update indentation * freeze getpath * change getpath.h path * remove unmatched condition * make cmake_debug_postfix optional * skip tk in ci * set python3 exe * Revert "remove unmatched condition" This reverts commit 06dfd6a. * add missing endif * restore missing freeze command invocation * build getpath for 3.11 * Revert "build getpath for 3.11" This reverts commit 58100e1. * use proper getpath * Revert "use proper getpath" This reverts commit 2e054df. * add back 3.11 test * Revert "Revert "use proper getpath"" This reverts commit 226a146. * set expected c standard * should autodetect c standard * Revert "Revert "Revert "use proper getpath""" This reverts commit 5967772. * add dl_nt.c to _freeze_importlib for windows * add config.c to _freeze_importlib win32 * set fail-fast * search for system python3 automatically * add PYTHONPATH to getpath.c * Revert "add config.c to _freeze_importlib win32" This reverts commit 51aadd8. * Revert "add dl_nt.c to _freeze_importlib for windows" This reverts commit 31e1c2b. * PYTHONPATH fixes * roll forward patches * explicitly add lib directory to PYTHONPATH * add MS_DLL_ID and patch config_minimal on PC * fix VPATH * explicitly point PYTHONPATH to stdlib * add default abiflags * add check for pipe syscall * fix missing macro in _msi.c * add check for umask syscall * add missing syscall checks * update PYTHONPATH for windows * use proper delimiter * escape semicolon * Drop list for now * add getsockname * add more missing syscalls * add test patch * test * test * test * check for socket func * add HAVE_ACCEPT * remove test patch * print value for NDBM_USE * add missing stub function to getpath_noop * run tests with verbose * add chmod * add gethostbyaddr * refactor sqlite3 sources * fix extension list * install certifi in test * add test timeout --------- Co-authored-by: Minmin Gong <gongminmin@msn.com>
|
when we can push to the main, guys? Hope community can check and merge to the base version asap. thanks in advance |
|
I ended up forking this repo here, which also now includes support for 3.11 and 3.12 |
|
Thanks for the reminder and help with this 🙏 Will review shortly 🚀 |
superb. update @bjia56 |
|
Handled by #350 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative implementation of #281, but based on the most recent upstream commits. Some of the changes are inspired by the work done in the linked previous PR.
Verified to produce working dynamic Python executables for Windows x86_64, Mac x86_64/arm64, Linux x86_64/arm32/arm64. I did not thoroughly test all possible cmake configurations, so there may be code paths that still need some future work.
I have also included #342 in this, since the builds I am making for my own projects require universal2 binaries. Let me know if that should be split out.
Resolves #344