-
Notifications
You must be signed in to change notification settings - Fork 152
Set of patches successfully used in FreeOrion project #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
o01eg
wants to merge
117
commits into
python-cmake-buildsystem:master
Choose a base branch
from
o01eg:freeorion-patches-android-5
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Set of patches successfully used in FreeOrion project #349
o01eg
wants to merge
117
commits into
python-cmake-buildsystem:master
from
o01eg:freeorion-patches-android-5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Disable C4101 'identifier' : unreferenced local variable for libpython. * Disable C4018 'expression' : signed/unsigned mismatch for libpython. * Disable C4244 'conversion' conversion from 'type1' to 'type2', possible loss of data for libpython. * Disable C4996 The compiler encountered a deprecated declaration. for libpython.
This is required when using multi-config cmake generators.
This reverts commit 5732cda.
This reverts commit 06dfd6a.
This reverts commit 58100e1.
This reverts commit 2e054df.
Translated to CMake from a patch on the Yocto project: http://cgit.openembedded.org/openembedded-core/tree/meta/recipes-devtools/python/python3/0002-Don-t-do-runtime-test-to-get-float-byte-order.patch?h=zeus It avoids the execution of a program on the target device, and produces a clearer endianness result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those patches were tested with Python 3.10.16 version on MacOS, Windows and Android.