cmake: Simplify removing use of IS_PY3, PY3_BUILTIN and PY3_ALWAYS_BUILTIN #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempt to set target properties only if target was effectively added. Checking if the `ENABLE_<upper_extension_name>` is set to ON only indicates that the extension was requested.
…ILTIN
This commit removes use of `IS_PY3` and replaces both `${PY3_BUILTIN}` and
`${PY3_ALWAYS_BUILTIN}` respectively with `BUILTIN` and `ALWAYS_BUILTIN`.
91960e6 to
7f908da
Compare
|
Working toward addressing: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IS_PY3and replaces both${PY3_BUILTIN}and${PY3_ALWAYS_BUILTIN}respectively withBUILTINandALWAYS_BUILTIN.ENABLE_<upper_extension_name>is set to ON only indicates that the extension was requested.