Simplify removing versioned variables #371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up of 7b6b8fa ("datetime, time: Fix build conditionally including _time.c or timemodule.c", 2022-01-18)
Remove the following variables from `cmake/python/CMakeLists.txt`: * `subdir_3` Remove the following variables from `cmake/extensions/CMakeLists.txt`: * `crypt3_NAME` * `datetime3_NAME` and `datetime3_SOURCES` * `time_SOURCES` * `thread3_NAME` and `thread3_SOURCES` * `winreg3_NAME` * `bz2_3_NAME` * `dbm3_SOURCES` and `dbm_name` * `gdbm3_SOURCES` and `gdbm_name` Rename the following variables in `cmake/libpython/CMakeLists.txt`: * `init_return_type_3` -> `init_return_type` * `init_prefix_3` -> `init_prefix`
|
Working toward addressing: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the following variables from
cmake/python/CMakeLists.txt:subdir_3Remove the following variables from
cmake/extensions/CMakeLists.txt:crypt3_NAMEdatetime3_NAMEanddatetime3_SOURCEStime_SOURCESthread3_NAMEandthread3_SOURCESwinreg3_NAMEbz2_3_NAMEdbm3_SOURCESanddbm_namegdbm3_SOURCESandgdbm_nameRename the following variables in
cmake/libpython/CMakeLists.txt:init_return_type_3->init_return_typeinit_prefix_3->init_prefixAlso fix
extension_timesource by associating_time.cif Python is 3.2: Follow-up of 7b6b8fa ("datetime, time: Fix build conditionally including _time.c or timemodule.c", 2022-01-18)