Skip to content

Attempt to fix support for python 3.0 to 3.5 #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 5, 2025
Merged

Attempt to fix support for python 3.0 to 3.5 #374

merged 2 commits into from
May 5, 2025

Conversation

jcfr
Copy link
Contributor

@jcfr jcfr commented May 5, 2025

  • Re-introduce unicode defines to support to support Python 3.0 to 3.2: Partially reverts b979b95 ("cmake: Remove obsolete defines from pyconfig.h and pyconfig.h.in", 2025-04-29) and 6391889 ("cmake: Remove support for building CPython 2.7", 2025-04-28).
  • Attempt to fix build for Python 3.0 to 3.5: In an attempt to workaround issue to link against newer openssl library, extensions _ssl and _hashlib have been excluded for Python < 3.5

jcfr added 2 commits May 5, 2025 14:00
@jcfr
cmake: Re-introduce unicode defines to support to support Python 3.0 …
f30ae8e 
…to 3.2

Partially reverts b979b95 ("cmake: Remove obsolete defines from pyconfig.h and pyconfig.h.in", 2025-04-29)
and 6391889 ("cmake: Remove support for building CPython 2.7", 2025-04-28).
@jcfr
cmake: Attempt to fix build for Python 3.0 to 3.5
3709d97 
In an attempt to workaround issue to link against newer openssl library,
extensions `_ssl` and `_hashlib` have been excluded for Python < 3.5
@jcfr jcfr enabled auto-merge (rebase) May 5, 2025 18:02
@jcfr
Copy link
Contributor Author

jcfr commented May 5, 2025

Working toward addressing:

@jcfr jcfr merged commit 002ce42 into python-cmake-buildsystem:master May 5, 2025
15 checks passed
@jcfr jcfr deleted the attempt-to-fix-support-for-python-3.0-to-3.5 branch May 5, 2025 18:17
@jamesobutler
Copy link
Contributor

@jcfr You are going to add early Python 3 versions to the CI matrix?

@jcfr
Copy link
Contributor Author

jcfr commented May 5, 2025 •
edited
Loading

You are going to add early Python 3 versions to the CI matrix?

These were just added for completeness and no additional work will be done to support older version. The focus is 3.10 and above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcfr @jamesobutler