Skip to content

fix: disable vcdiv64.asm on non-x86_64 Windows #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: disable vcdiv64.asm on non-x86_64 Windows #409

wants to merge 3 commits into from

Conversation

bjia56
Copy link
Contributor

@bjia56 bjia56 commented May 30, 2025

jamesobutler
jamesobutler reviewed May 30, 2025
View reviewed changes
Copy link
Contributor

@jamesobutler jamesobutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bjia56 Do you need Windows on ARM testing in the CI? I see that there is now the windows-11-arm GitHub runner

https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories

@bjia56
Copy link
Contributor Author

bjia56 commented May 30, 2025

@jamesobutler It's a good idea, however I'm not too sure how to plug it into the existing GH runner setup.

@jamesobutler
Copy link
Contributor

Adding Windows 11 arm building would likely need to be restricted to the Python 3.11+ builds. It appears that the Python organization distributed Windows arm64 installers for Python 3.11.0 (https://www.python.org/downloads/release/python-3110/), but did not for earlier versions such as Python 3.10.7 (https://www.python.org/downloads/release/python-3107/).

@bjia56
Copy link
Contributor Author

bjia56 commented May 30, 2025

fwiw, I was able to get 3.9 and 3.10 builds when testing my portable fork here: bjia56/portable-python#129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesobutler jamesobutler jamesobutler left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjia56 @jamesobutler