chore: Simplify add_custom_(command|target) by removing obsolete syntax
#410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntax
Following the CMake minimum required version update from 3.15.6 to 3.20.6,
`add_custom_command` and `add_custom_target` now automatically prepend the
emulator (from the `CROSSCOMPILING_EMULATOR` property) to the target executable
path when cross-compiling.
This eliminates the need for manual command construction previously required to handle emulated targets.
Note: When the `COMMAND` argument uses constructs like `${CMAKE_COMMAND} -E env`
(e.g. in `generate_pegen_metaparser` and `generate_pegen_parse` in the top-level
`CMakeLists.txt`), the paths to `CMAKE_CROSSCOMPILING_EMULATOR` and target executable
must be explicitly specified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the CMake minimum required version update from 3.15.6 to 3.20.6,
add_custom_commandandadd_custom_targetnow automatically prepend the emulator (from theCROSSCOMPILING_EMULATORproperty) to the target executable path when cross-compiling.This eliminates the need for manual command construction previously required to handle emulated targets.
Note
When the
COMMANDargument uses constructs like${CMAKE_COMMAND} -E env(e.g. ingenerate_pegen_metaparserandgenerate_pegen_parsein the top-levelCMakeLists.txt), the paths toCMAKE_CROSSCOMPILING_EMULATORand target executable must be explicitly specified.Working toward addressing: