fix: Work around CMake issue #26993 explicitly propagating extension definitions #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88fa787 to
4c7319b
Compare
…nd pgen executables
…definitions Due to CMake's lack of support for generator expressions in the `SOURCE` argument of `set_property()`, compile definitions associated with sources cannot be reliably applied via set_property() when conditional logic is used. See https://gitlab.kitware.com/cmake/cmake/-/issues/26993 This patch documents the issue and ensures that compile definitions from built-in extensions are explicitly propagated to relevant targets using `target_compile_definitions()`, preserving intended build behavior.
4c7319b to
d44717c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to CMake's lack of support for generator expressions in the
SOURCEargument ofset_property(), compile definitions associated with sources cannot be reliably applied via set_property() when conditional logic is used.See https://gitlab.kitware.com/cmake/cmake/-/issues/26993
This patch documents the issue and ensures that compile definitions from built-in extensions are explicitly propagated to relevant targets using
target_compile_definitions(), preserving intended build behavior.Working toward addressing: