ConfigureChecks: Avoid false positive remove USE_SYSTEM_LibFFI warning #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since options `LibFFI_INCLUDE_DIR` and `LibFFI_LIBRARY` may be specified independently of setting `USE_SYSTEM_LibFFI`, this commit removes the corresponding warning that is displayed despite of setting the expected options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since options
LibFFI_INCLUDE_DIRandLibFFI_LIBRARYmay be specified independently of settingUSE_SYSTEM_LibFFI, this commit removes the corresponding warning that is displayed despite of setting the expected options.Working toward addressing: