Additional wrappers to SLICOT functions #1
Conversation
|
For posterity, the prior pull request that is referenced in the opening post is jgoppert/Slycot#8 |
| @@ -410,13 +430,13 @@ subroutine sb10ad(job,n,m,np,ncon,nmeas,gamma,a,lda,b,ldb,c,ldc,d,ldd,ak,ldak,bk | |||
| double precision intent(out), dimension(ncon,nmeas), depend(ncon,nmeas) :: dk | |||
| integer intent(hide), depend(dk) :: lddk=shape(dk,0) | |||
| double precision intent(out), dimension(2*n,2*n), depend(n) :: ac | |||
| integer intent(hide), depend(ac) :: ldac=shape(ac,0) | |||
| integer intent(hide), depend(ac) :: ldak=shape(ac,0) | |||
There was a problem hiding this comment.
this (and the other changes to sb10ad) undo the fix in 42cdeb8 -- this is why the unit test fails.
|
@mdclemen Can you rebase to address the following?
|
| @@ -876,7 +876,7 @@ def ab09bd(dico,job,equil,n,m,p,A,B,C,D,nr=None,tol1=0,tol2=0,ldwork=None): | |||
| e = ArithmeticError('The computation of Hankel singular values failed') | |||
| e.info = out[-1] | |||
| raise e | |||
| nr,A,B,C,D,hsv = out[:-2] | |||
| Nr,A,B,C,D,hsv = out[:-2] | |||
| return nr, A[:Nr,:Nr], B[:Nr,:], C[:,:Nr],D[:,:], hsv | |||
There was a problem hiding this comment.
should that be return Nr, [etc.] ? (This is just by comparison with ab09ad, which returns Nr, not nr.)
|
@slivingston, trying to rebase has totally screwed my repo. I am going to start over. My git status is novice at best. |
|
I can assist with rebasing or modifying changesets via email or on IRC provided by OFTC. For the latter, there is a web client that you can use: https://webchat.oftc.net/?channels=#python-control. Also, we can simply avoid any modifications to commits during review and then decide what to do when the final, overall patch is good to go. |
|
I closed this pull-request and started a new one with a clean commit. On Fri, Aug 19, 2016 at 3:57 PM, Scott C. Livingston <
|
I've added wrappers to SLICOT functions SB03OD and AB09BD. I have an open pull request on jgoppert/Slycot, but that fork seems to be abandoned.