GitHub workflow #140

bnavigator · 2020-12-30T15:25:48Z

See https://github.com/bnavigator/Slycot/tree/github-workflow for the GitHub Actions results.

Tasks:

Ubuntu
- setup.py install
- Conda
- Pip
macOS
- Conda
- Pip
Windows
- Conda
Python Versions: 3.6 to 3.9
Streamline LAPACK linking. The conda-forge packages nowadays always link against the reference implementation but you can use a different one (=the same as numpy) during runtime.
do Add CI test for import slycot; slycot.test #137 : Test slycot.test()

Builds on #143

roryyorke · 2020-12-30T15:48:05Z

conda-recipe-generic/build.sh

@@ -0,0 +1,3 @@
+$PYTHON setup.py build_ext install -- \
+        -DNumPy_INCLUDE_DIR=${SP_DIR}/numpy/core/include \


I just filed scikit-build/scikit-build#524 because I think scikit-build should find the venv numpy before system numpy.

This recipe is taken from the conda-forge feedstock.

Are we sure the problem is not the fiddling with the python path in

Slycot/CMakeLists.txt

Lines 21 to 32 in 055e9d6

# base site dir, use python installation for location specific includes

execute_process(

COMMAND "${PYTHON_EXECUTABLE}" -c

"import os,numpy; print(os.path.dirname(numpy.__path__[0]))"

OUTPUT_VARIABLE PYTHON_SITE

OUTPUT_STRIP_TRAILING_WHITESPACE)

if(WIN32)

string(REPLACE "\\" "/" PYTHON_SITE ${PYTHON_SITE})

endif()

find_package(PythonLibs REQUIRED)

find_package(NumPy REQUIRED)

?

find_package(NumPy ) is not a scikit-build feature but from CMake.

find_package(NumPy ) is not a scikit-build feature but from CMake.

I am wrong here. Scikit-build's FindNumpy is a different thing than FindPython with NumPy component from CMake.

Cool - that find_package finds the right thing without extra magic. I've noted that on the scikit-build issue.

It might not help us (see my comment linking to the disussion there), because it sets different output variables in cmake. We need to find the correct f2py too. I was experimenting with FindF2PY from scikit-build yesterday. Curious if all the old windows hacks in setup.py and the CMake files are still necessary. They do not seem to work for my setup in the workflow so far.

roryyorke · 2020-12-30T15:53:43Z

Thanks for working on this!

It looks like this PR will drop Python <= 3.5 (I think Numpy is about to go >= 3.7 anyway); I think that's worth explicitly noting.

bnavigator · 2020-12-30T16:31:34Z

It looks like this PR will drop Python <= 3.5 (I think Numpy is about to go >= 3.7 anyway); I think that's worth explicitly noting.

See also python-control/python-control#481

bnavigator · 2020-12-30T17:13:21Z

Streamline conda recipes / sync with conda-forge feedstock?

Streamline LAPACK linking? The conda-forge packages nowadays always link against the reference implementation but you can use a different one (=the same as numpy) during runtime.

@repagh, I remember that prior to the 0.4.0 release you advocated for keeping these different conda recipes. Is this still true? Do we need to test them all?

roryyorke · 2021-01-24T08:56:39Z

This looks good, but I'm in no position to review the details. One thing I did wonder about: why are the test matrices generated by scripts, and not known upfront?

Will we remove Travis CI config after this is merged?

For anyone else reviewing, you can see output here: https://github.com/bnavigator/Slycot/actions

The warnings there seem to be due to a third-party package; @bnavigator has already queried it conda-incubator/setup-miniconda#132 (comment)

Given that free Travis CI is disappearing, I think we should merge this. @murrayrm , @repagh, objections?

bnavigator · 2021-01-24T09:23:58Z

why are the test matrices generated by scripts, and not known upfront?

The test matrix generation is based upon which wheel and conda packages are created. With all the exceptions and special cases for combinations of OS and LAPACK implementation, statically defining the matrices would be very complicated.

…uctions

murrayrm · 2021-01-24T22:32:10Z

No objections to merging on my end. I note that the full CI build seems to take ~30 minutes, but of course it is testing on all sorts of different configurations and OS's.

bnavigator · 2021-01-24T23:43:04Z

Most of the time is wasted by the conda resolver. Especially on Windows. This could be fixed be a frozen environment, which we update manually, but that is maybe something for another PR.

bnavigator mentioned this pull request Dec 30, 2020

Consider switching CI to Github Workflows, include Windows #108

Closed

bnavigator linked an issue Dec 30, 2020 that may be closed by this pull request

Consider switching CI to Github Workflows, include Windows #108

Closed

roryyorke reviewed Dec 30, 2020

View reviewed changes

bnavigator force-pushed the github-workflow branch 3 times, most recently from 12aefb6 to 65ff690 Compare December 31, 2020 14:34

bnavigator linked an issue Dec 31, 2020 that may be closed by this pull request

Add CI test for import slycot; slycot.test #137

Closed

bnavigator force-pushed the github-workflow branch 8 times, most recently from 4d9f1d8 to 44691f0 Compare January 7, 2021 19:44

This was referenced Jan 7, 2021

use __call__ instead of evalfr in lti system classes python-control/python-control#449

Merged

Clean build setup #142

Merged

bnavigator force-pushed the github-workflow branch 4 times, most recently from 3325730 to 8f1c90b Compare January 8, 2021 14:40

roryyorke mentioned this pull request Jan 9, 2021

Merge conda recipes #143

Merged

bnavigator force-pushed the github-workflow branch 2 times, most recently from 870ee8c to c456fdd Compare January 10, 2021 18:36

bnavigator mentioned this pull request Jan 10, 2021

CI tests via GitHub actions and conda python-control/python-control#504

Merged

bnavigator force-pushed the github-workflow branch 2 times, most recently from b7801b6 to 05a0ad9 Compare January 10, 2021 22:33

bnavigator force-pushed the github-workflow branch 3 times, most recently from 56de0c9 to 9abde05 Compare January 11, 2021 20:06

merge conda-recipes

77b28a4

bnavigator force-pushed the github-workflow branch 2 times, most recently from 6c47df1 to 8c216a3 Compare January 11, 2021 22:06

bnavigator marked this pull request as ready for review January 11, 2021 23:03

bnavigator mentioned this pull request Jan 11, 2021

build & test using GitHub Workflows #80

Closed

bnavigator force-pushed the github-workflow branch from 8c216a3 to f63397c Compare January 14, 2021 00:05

bnavigator added 6 commits January 24, 2021 10:25

Update REAMDE.rst for conda single recipe and general compiling instr…

f5c5db4

…uctions

update MANIFEST

2e22674

Github actions workflow with split jobs

4893608

Update README.rst and MANIFEST.in

d1c056a

add fast sniff build

2a6a98f

fix coveralls endpoint service

c58c564

bnavigator force-pushed the github-workflow branch from 898421a to c58c564 Compare January 24, 2021 09:27

roryyorke merged commit a070bbb into python-control:master Jan 30, 2021

bnavigator deleted the github-workflow branch May 3, 2022 19:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GitHub workflow #140

GitHub workflow #140

bnavigator commented Dec 30, 2020 •

edited

Loading

roryyorke Dec 30, 2020

bnavigator Dec 30, 2020

bnavigator Dec 31, 2020

bnavigator Dec 31, 2020

roryyorke Jan 1, 2021

bnavigator Jan 1, 2021

roryyorke commented Dec 30, 2020

bnavigator commented Dec 30, 2020

bnavigator commented Dec 30, 2020

roryyorke commented Jan 24, 2021

bnavigator commented Jan 24, 2021

murrayrm commented Jan 24, 2021

bnavigator commented Jan 24, 2021

		@@ -0,0 +1,3 @@
		$PYTHON setup.py build_ext install -- \
		-DNumPy_INCLUDE_DIR=${SP_DIR}/numpy/core/include \

	# base site dir, use python installation for location specific includes
	execute_process(
	COMMAND "${PYTHON_EXECUTABLE}" -c
	"import os,numpy; print(os.path.dirname(numpy.__path__[0]))"
	OUTPUT_VARIABLE PYTHON_SITE
	OUTPUT_STRIP_TRAILING_WHITESPACE)
	if(WIN32)
	string(REPLACE "\\" "/" PYTHON_SITE ${PYTHON_SITE})
	endif()

	find_package(PythonLibs REQUIRED)
	find_package(NumPy REQUIRED)

GitHub workflow #140

GitHub workflow #140

Conversation

bnavigator commented Dec 30, 2020 • edited Loading

Builds on #143

roryyorke Dec 30, 2020

Choose a reason for hiding this comment

bnavigator Dec 30, 2020

Choose a reason for hiding this comment

bnavigator Dec 31, 2020

Choose a reason for hiding this comment

bnavigator Dec 31, 2020

Choose a reason for hiding this comment

roryyorke Jan 1, 2021

Choose a reason for hiding this comment

bnavigator Jan 1, 2021

Choose a reason for hiding this comment

roryyorke commented Dec 30, 2020

bnavigator commented Dec 30, 2020

bnavigator commented Dec 30, 2020

roryyorke commented Jan 24, 2021

bnavigator commented Jan 24, 2021

murrayrm commented Jan 24, 2021

bnavigator commented Jan 24, 2021

bnavigator commented Dec 30, 2020 •

edited

Loading