I feel like this is failing because of an issue with the python3.2 build.

Python 3.2 is no longer maintained as of Feb 2016 [1], so I will remove it from the Travis CI test platforms.

[1] https://www.python.org/dev/peps/pep-0392/#lifespan

I think there is an issue with the Python 3.4 build and my additions aren't even being tested.

I do not know why Python 3.4 jobs on Travis CI are failing. I first noticed it after merging PR #4 and have been trying to debug it.

I did a bit of debugging on this. The problem appears to be that in python 3.4 there is a bug of some sort in numpy and the command config.add_subpackage('slycot') in setup.py generates an error because it can't fine the module import.machinery. A fix for this is to include that module at the top of setup.py using the code:

# Fix a bug in python v3.4 installation                                         
if (sys.version_info[0:2] == (3,4)):
    import importlib.machinery

Not sure why this only happens on python 3.4, but if you update to include that fix then we should be able to merge this pull request.

@murrayrm, thanks for debugging, this should be ready to merge.

@mdclemen did you rebase? The commit messages and authorship appear to be mixed and not valid. Can you try to rebase again? I am available to assist in the process, here or via email.

I did rebase, what is the issue?

On Nov 18, 2016 10:08 AM, "Scott C. Livingston" notifications@github.com
wrote:

@mdclemen https://github.com/mdclemen did you rebase? The commit
messages and authorship appear to be mixed and not valid. Can you try to
rebase again? I am available to assist in the process, here or via email.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#2 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHIA65JspxInbhgBnZdltykAydq7cW5lks5q_emvgaJpZM4Jo4k9
.

e.g., compare the commit message of fa3f9e9 with the changes of that commit.

@slivingston: I'm also confused. I show that this is read to be merged into master. I looked at the commit message for fa3f9e9, but didn't see any flags? What am I missing?

I undid my rebase.

@mdclemen Thanks! The new rebase is good for me.

@murrayrm The merge would have succeeded, but some of the commit messages were not appropriate for the changesets. The old commits are gone because the rebase was re-done, so I cannot furnish evidence unless the Web Archive or some other site captured them.

Thanks @slivingston. I'll leave to you to merge since you are the assignee -:).

@mdclemen In the future, the pull request should include tests. In the case of newly wrapped routines, tests should be provided that check expected behavior, e.g., as in test_sb02ad in slycot/tests/test.py

Currently there is little testing, so I think it is OK to merge changes from here and, then, work on improving test coverage for the entire package.