Fix: a and c matrices must have at least one column in td04ad_r #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to python-control/python-control#129 (comment)
Previously the a and c matrices submitted to SLICOT's
TD04AD
via Slycot'std04ad_r
could have zero columns if the submitted transfer functions were constant. This is reasonable, but f2py (or possibly other numpy component) objected. The fix is to ensure a minimum of 1 column; this doesn't affect the result, sinceTD04AD
returns the number of required states, and only the required parts of the a, b, and c matrices are returned.Unfortunately a similar fix does not work for
td04ad_c
; I believe this is due to a bug in SLICOT. I'll file a separate issue for that.This does not address the case when there are either no inputs (
m=0
) or outputs (p=0
); I suspect a similar failure would occur in that case.