-
Notifications
You must be signed in to change notification settings - Fork 439
Response Functions as Member Functions? #1084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Seems easy enough to implement. Note that
One thing that is missing from the Time respones ( If you or someone else wants to take a pass at this, it would be a nice contribution. It will require some refactoring, at least for |
Thank you for quick response and the hints regarding |
Ok, i have finally found some time for this. Refactoring it so that I think it would be a good idea to deprecate passing limits in I implemented the automatic frequency range determination for the Other than that I added every function that seemed sensible to me and that can take a system as its first argument as a member to |
Hi,
are there some ideological reasons why the response functions are not available as member functions for the respective system classes like they are in sicpy.signal? I feel like this would make the library a bit nicer to use.
I am willing to implement this myself, I just want to ensure that it would actually have a change of getting merged before putting in the effort.
Just to be clear, I mean forwarding the calls or aliasing the methods, not refactoring the code.
The text was updated successfully, but these errors were encountered: