Skip to content

CI failures in doctest, examples #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
murrayrm opened this issue Mar 2, 2025 · 1 comment · Fixed by #1137
Closed

CI failures in doctest, examples #1136

murrayrm opened this issue Mar 2, 2025 · 1 comment · Fixed by #1137

Comments

@murrayrm
Copy link
Member

murrayrm commented Mar 2, 2025

From #1135 (also in #1133):

I see two failures on CI , but I can't see that these changes caused them:

first, in doctest-linux: roryyorke/python-control/actions/runs/13612156165/job/38050709282

Traceback
=========

      File "/home/runner/miniconda3/envs/doctest-env/lib/python3.12/site-packages/sphinx/events.py", line 415, in emit
        raise ExtensionError(
    sphinx.errors.ExtensionError: Handler <function html_collect_pages at 0x7f36a35016c0> for event 'html-collect-pages' threw an exception (exception: module 'sphinx.util' has no attribute 'console')
which seems to be https://github.com/sphinx-doc/sphinx/issues/13352.

Then in install-examples: roryyorke/python-control/actions/runs/13612156159/job/38050709274

ModuleNotFoundError: No module named 'autoreload'
@roryyorke
Copy link
Contributor

I think the relevant error is the one you showed in #1133; Internet search on that leads to

ipython/ipython#14808

and

ipython/ipython#14807

Maybe for both problems we need to limit the version of the relevant package (sphinx-doc, IPython) used in the install? I think Ben's previously used '!=' magic to prevent specific package versions being used, rather than '<' or '<=', but I guess whatever works. See e.g. https://github.com/fpsim/fpsim/pull/493/files which fixes the sphinx-doc error for that project.

@roryyorke roryyorke mentioned this issue Mar 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix CI doctest, install-examples roryyorke/python-control
2 participants
@roryyorke @murrayrm