Skip to content

Fix Latex not being rendered in HTML output in VSCode #1133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2025
Merged

Fix Latex not being rendered in HTML output in VSCode #1133

merged 1 commit into from
Mar 3, 2025

Conversation

lkies
Copy link
Contributor

@lkies lkies commented Mar 1, 2025 •
edited
Loading

...by adding a blanket _repr_markdown_ for InputOutputSystem which is the same as _repr_html_ but the renderer for _repr_markdown_ will also render contained Latex.

Closes #1132

@lkies
fix latex not being rendered in html output in VSCode
bb35a88 
by adding a blanket _repr_markdown_ InputOutputSystem which is the same as _repr_html_ but the renderer for _repr_markdown_ will also render contained latex
@coveralls
Copy link

Coverage Status

coverage: 94.745% (+0.001%) from 94.744%
when pulling bb35a88 on lkies:fix-repr
into f6799ab on python-control:main.

@murrayrm
Copy link
Member

murrayrm commented Mar 2, 2025

@lkies It looks like _repr_markdown breaks some unit tests. I tried running this under MacOS and it was OK, so seems to be specific to linux.

The doctest error is coming from Sphinx:

      File "/home/runner/miniconda3/envs/doctest-env/lib/python3.12/site-packages/sphinx/events.py", line 415, in emit
        raise ExtensionError(
    sphinx.errors.ExtensionError: Handler <function html_collect_pages at 0x7fcd3a5116c0> for event 'html-collect-pages' threw an exception (exception: module 'sphinx.util' has no attribute 'console')

The examples error is coming from singular_values_plot.ipynb. When the following block is executed

%matplotlib nbagg
# only needed when developing python-control
%load_ext autoreload
%autoreload 2

it generates the error

ModuleNotFoundError: No module named 'IPython.extensions.deduperreload'

This was referenced Mar 2, 2025
Merged
Closed
@lkies
Copy link
Contributor Author

lkies commented Mar 2, 2025

@murrayrm so since it seems that this is not my fault I will wait until #1137 is merged an then update my PR?

@murrayrm murrayrm added this to the 0.10.2 milestone Mar 3, 2025
@murrayrm murrayrm merged commit 45a6a2a into python-control:main Mar 3, 2025
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.2
Development

Successfully merging this pull request may close these issues.

Latex is not rendered in HTML output of in VSCode
3 participants
@lkies @coveralls @murrayrm