Skip to content

Add to conda-forge #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jgoppert opened this issue Oct 3, 2016 · 8 comments
Closed

Add to conda-forge #115

jgoppert opened this issue Oct 3, 2016 · 8 comments

Comments

@jgoppert
Copy link
Contributor

jgoppert commented Oct 3, 2016

https://github.com/conda-forge

They have a really done a great job here, the CI builds on OSX, linux, windows, and then creates conda packages ready for install.

I just recently moved my package over: https://github.com/dronecrew/px4tools

@jgoppert
Copy link
Contributor Author

@cwrowley Want to try to tackle this with me?

@cwrowley
Copy link
Contributor

Sure, looks really cool. Some issues I've run into previously when I made some conda packages:

  • I never was able to figure out how to get SLICOT to link against LAPACK on OSX (I did get Linux to work though). It's likely other people have figured that out for other packages on conda-forge though.
  • I have no clue about Windows.

@repagh
Copy link
Member

repagh commented Jun 26, 2017

Hi guys,

This came on my list too, want to move to a python 3 installation for our aerospace Bsc control + scientific computing and programming needs.

I have got working recipes now for both Slycot and python-control, tested for both Linux and OSX. Still have to fire up a VirtualBox Windows and check there, I started, but had to break off when it went into one of these endless update sessions.

I am using the conda-supplied compilers and libraries, so I think it should be multi-platform safe.

To be found at https://github.com/repagh/staged-recipes.git

For Slycot I am still pointing to my own version, because anaconda uses a new LAPACK library, that had some obsoleted routines that Slycot was using. Have a pull request in the pipeline for that.

Since you raised this issue, I thought I would ask first. If you are OK with this, I will create the pull request for conda-forge.

I am currently pointing to the master for both control and Slycot, but that is not very pretty. It would be nicer to point to a real release for conda-forge. If conda-forge makes python-control more accessible to many people it would be good to define releases more often; 0.7.0 is 2 years old now, and plenty of fixes have been done since then. Who is now organising the releases?

@repagh
Copy link
Member

repagh commented Jun 26, 2017

conda-forge/staged-recipes#3053

Someone beat us to this, both for Slycot and control. The Slycot version circumvents the problems with newer lapack by being based on openblas.

This still means that a 2 yr old control will end up in conda. So issuing a new release now & then is still relevant.

@slivingston
Copy link
Member

@repagh tonight or tomorrow I plan to cut a new release for control. Regarding the general question of who organises the releases, thus far it has been ad hoc and previously @cwrowley and @murrayrm have executed the process of releasing.

@moorepants
Copy link

moorepants commented Jun 27, 2017

Done: https://github.com/conda-forge/control-feedstock

slycot is currently only built for linux and osx though.

@slivingston
Copy link
Member

for posterity, here is the conda-smithy repo for slycot: https://github.com/conda-forge/slycot-feedstock

@slivingston
Copy link
Member

@moorepants thanks for creating the upstream PRs that led to the control and slycot conda-smithy repos.

@repagh thanks for also creating working recipes. Next time I will try to use this issue tracker more effectively to prevent repeated effort.

Regarding releases, I am happy to much more frequently tag bugfix releases, wherein only the micro (or "patch") number increases. As for the second number of the version triple, I think that we can increase the pace to every 6 months or less, depending on new features or desired API changes.

@jgoppert As commented by @moorepants above, conda-forge builds of slycot for Windows are not operational yet. However, I do not interpret your opening post on this issue as requiring support for Windows in order to consider this issue resolved. It might be worth making an issue in the tracker of Slycot. If I am missing something, please re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants