Skip to content

Figure 6 in examples/pvtol-nested-ss.py is incorrect #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
murrayrm opened this issue Jun 9, 2019 · 3 comments
Closed

Figure 6 in examples/pvtol-nested-ss.py is incorrect #309

murrayrm opened this issue Jun 9, 2019 · 3 comments
Labels
Milestone

Comments

@murrayrm
Copy link
Member

murrayrm commented Jun 9, 2019

There is something wrong with the figure that is being plotted in examples/pvtol-nested-ss.py, Figure 6. This should be a Bode plot of the loop transfer function with some lines for the unity gain and 180 degree phase. But what comes out is just the gain and phase lines (no Bode plot). This doesn't seem to be due to any recent changes, so must be something that broke a while ago. Probably having to do with the way that "hold" and re-using axes works.

Also: it seems to be OK in 'examples/pvtol-nested.py', so should be something easy to track down and fix.

@billtubbs
Copy link
Contributor

Hope I didn't break it.

@murrayrm
Copy link
Member Author

murrayrm commented Jun 9, 2019

@billtubbs I checked and it is the same before and after PR #307 and I get the same results => most have broken earlier...

murrayrm added a commit to murrayrm/python-control that referenced this issue Jan 2, 2020
@murrayrm murrayrm added this to the 0.8.3 milestone Jan 3, 2020
@murrayrm
Copy link
Member Author

murrayrm commented Jan 3, 2020

Fixed in PR #361

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants