Skip to content

Robust MIMO Example - Fix computation of Sigma #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rega0051 opened this issue May 19, 2020 · 0 comments · Fixed by #428
Closed

Robust MIMO Example - Fix computation of Sigma #406

rega0051 opened this issue May 19, 2020 · 0 comments · Fixed by #428

Comments

@rega0051
Copy link

rega0051 commented May 19, 2020 •
edited
Loading

python-control/examples/robust_mimo.py

Line 47 in 03183d1

sjw = (m*np.exp(1j*p*np.pi/180)).transpose(2, 0, 1)

freqresp returns the phase already returns the phase in units of radians.
Computation the complex response should be:
sjw = (m * np.exp(1j * p)).transpose(2, 0, 1)
bnavigator added a commit to bnavigator/python-control that referenced this issue Jul 4, 2020
@bnavigator
fix python-control#406
8584f40
@bnavigator bnavigator mentioned this issue Jul 4, 2020
Merged
murrayrm pushed a commit that referenced this issue Jul 11, 2020
@bnavigator
Fix phase for triv_sigma in examples/robust_mimo.py (#428)
2777de3 
* fix issue #406

* more precise docstrings for *.freqresp()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix phase for triv_sigma in examples/robust_mimo.py bnavigator/python-control
1 participant
@rega0051