-
Notifications
You must be signed in to change notification settings - Fork 438
Move from legacy Travis CI integration to a Github Actions based system #446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I remember this was going to go away, but wasn't sure when. We need to set up a GitHub action instead. I'll try to do that in the next few days. |
I agree that a move to Github actions will be necessary at some time. Travis still reports the new run after the most recent merge. And the PR runs are still there just not reported on the PR pages. |
The PR run checks came back. Not sure, why. Probably a refresh of Travis' API tokens and rate limits. |
You (@bnavigator) apparently put in some sort of request to set up the GitHub/Travis CI integration. I got an e-mail asking for approval of the permissions and I approved. So presumably that turned things back on (and hopefully didn't break anything!). |
I think they even came back before the request. I tried to follow the migration advice from this guide. We are still on legacy though: Nothing broken yet. Please tell me when I am moving too fast! |
Note that this banner is currently popping up on travis-ci.org:
|
are they dropping free service for open source projects? |
They already did. But you can request for more free credits as they expire from Travis. For SciPy, we had to switch to GitHub Actions and Azure Pipelines for most of the CI work. We can't leave completely because we are building wheels for ppc64 and arm but python-control can. It's not that difficult to setup but certainly wastes some maintainer time |
I started to prepare a GitHub Actions workflow for Slycot last weekend (to close python-control/Slycot#108). Once I am done with that, doing the same for python-control, which uses pure python, should be easy. |
Comments from @bnavigator on additional improvements needed:
|
I'll generate a new PR to get some of these improvements in place. With regard to Linux only testing: since With regard to Travis (pulling from #504): I think we can leave Travis and GitHub Actions running for a few days, as we see whether new PRs and things are properly handled, but then I think we shift away from Travis completely. |
GitHub workflow results look good. And so fast! 🚀 😄 Originally posted by @bnavigator in #505 (comment) One thing I noticed: The test names derived from the matrix could be more concise. Just "1" for the PYTHON_CONTROL_ARRAY_AND_MATRIX=1 run does not really convey the nature of the job. |
Yes, the naming definitely leaves something to be desired. If anyone knows of a fix, let me know. Nice to have CI tests starting immediately and completing in single digits of minutes again. |
Use a |
I'm planning to shut down Travis CI this weekend and just rely on GitHub Actions after that. We can leave the Any issues? |
Travis CI is now shut down and we are relying on GitHub Actions for CI testing. |
The link to Travis CI seems broken. Maybe related to https://travis-ci.community/t/github-status-not-posted-on-commits-on-repositories-using-legacy-service-integration/7798/4
The text was updated successfully, but these errors were encountered: