Skip to content

rootlocus_pid_designer plot looks strange + needs documentation #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
murrayrm opened this issue Dec 31, 2021 · 1 comment · Fixed by #883
Closed

rootlocus_pid_designer plot looks strange + needs documentation #686

murrayrm opened this issue Dec 31, 2021 · 1 comment · Fixed by #883
Assignees
@sawyerbfuller

Comments

@murrayrm
Copy link
Member

From PR #684:

If I use the following code (from the now skipped unit test in control/tests/rootlocus_test.py:

syscont = ct.TransferFunction(1,[1, 3, 0])
ct.rootlocus_pid_designer(syscont, input_signal='r', Kp0=0.01,
    derivative_in_feedback_path=True)

then I get the following plot:

Sisotool_pid_designer_bug
@murrayrm murrayrm changed the title rootlocus_pid_designer plot looks strange rootlocus_pid_designer plot looks strange + needs documentation Jan 1, 2022
@murrayrm
Copy link
Member Author

murrayrm commented Jan 1, 2022

Also, there is currently no entry for rootlocus_pid_designer in the online documentation (from the docs/ directory).

@sawyerbfuller sawyerbfuller mentioned this issue Apr 14, 2023
Merged
@sawyerbfuller sawyerbfuller linked a pull request Apr 14, 2023 that will close this issue
fix blank bode plot in rootlocus_pid_designer #883
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sawyerbfuller sawyerbfuller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix blank bode plot in rootlocus_pid_designer sawyerbfuller/python-control
2 participants
@murrayrm @sawyerbfuller