-
Notifications
You must be signed in to change notification settings - Fork 438
gain offset using control.matlab.c2d using method='matched' ? #950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi John great to hear from you and happy holidays. Glad to see you are using or at the very least evaluating the library. The matched c2d is code I have never used before and it doesn’t look like we have a unit test for it, so there is a decent chance it is just a bug. Thanks for the report! One q - when you refer to gain, do you mean the DC gain of the two systems? |
murrayrm
added a commit
to murrayrm/python-control
that referenced
this issue
Dec 26, 2023
murrayrm
added a commit
to murrayrm/python-control
that referenced
this issue
Dec 26, 2023
Fixed in #951. New plot: |
murrayrm
added a commit
that referenced
this issue
Dec 26, 2023
Fix bug in matched transformation + address other issues in #950
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Compared results of
sysc = ct.TransferFunction([1, z], [1, p])
sysd = ct.matlab.c2d(sysc, Ts, method='bilinear')
sysd1 = ct.matlab.c2d(sysc, Ts, method='matched')
yields a sysd1 with a gain that is about 10x that of sysd - is that expected?
The text was updated successfully, but these errors were encountered: