-
Notifications
You must be signed in to change notification settings - Fork 438
Improve acker
pole placement doc
#1006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Oups, I didn't see PR #1007 and pushed my own commit to fix |
(mostly reverts commit commit 4f0e9b7)
Done! |
@pierre-haessig Thanks! I am going to squash-merge this because the second commit is not used after you resolved the conflict. |
Regarding the other two items in your opening post:
As an aside, I was not able to find a description of |
Neither did I. I only found an online copy of a unspecified Matlab version here: www.ece.northwestern.edu/local-apps/matlabhelp/toolbox/control/ref/acker.html (in the source code, the date 2002 is mentioned). I don't know when it was removed. [Edit: sorry, I didn't see you were mentioning the exact same link for Matlab's |
Hello,
This is a follow-up of #1004, still on pole placement, but now turning to
acker
docstring.As a first step, this adds a "See Also" section to
place
andplace varga
.However, I have two more ideas to extend this PR:
ValueError
ifB.shape[1] > 1
.