Skip to content

Add function to convert a system into observable canonical form #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2016

Conversation

yuina822
Copy link
Contributor

@yuina822 yuina822 commented Aug 7, 2016

Only for SISO systems

@coveralls
Copy link

coveralls commented Aug 7, 2016

Coverage Status

Coverage decreased (-0.5%) to 75.546% when pulling 06891be on yuina822:observable_form into 7b07af3 on python-control:master.

@murrayrm
Copy link
Member

murrayrm commented Aug 7, 2016

Can we put in some unit tests to confirm that this is working. (And while we are at it, perhaps add some unit tests for reachable canonical form?)

Also, there seems to be a a problem with the python 3.3 build (looks like a conda problem/version conflict) that we should sort out.

@mp4096
Copy link
Contributor

mp4096 commented Aug 7, 2016

I actually added two tests for the reachable canonical form in #101, see here. One can easily adapt them for the OCF.

@yuina822
Copy link
Contributor Author

yuina822 commented Aug 16, 2016

I have write a observable test unit 5f6139c. Thank you @mp4096 . Unobservable test didn't done well because exception handling for unobservable systems isn't added. I think we could add exception handling for unreachable/unobservable systems in canonical.py.

@coveralls
Copy link

coveralls commented Sep 8, 2016

Coverage Status

Coverage decreased (-0.5%) to 75.546% when pulling 98e71cb on yuina822:observable_form into cdd3e73 on python-control:master.

@murrayrm murrayrm merged commit 5a0645b into python-control:master Nov 18, 2016
@yuina822 yuina822 deleted the observable_form branch October 14, 2017 08:31
@murrayrm murrayrm added this to the 0.8.0 milestone Dec 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants