Skip to content

Move ctrlplot code prior to upcoming PR #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 21, 2024

Conversation

murrayrm
Copy link
Member

This PR moves around some functions from freqplot.py and timeplot.py to ctrlplot.py in preparation for an upcoming PR that is going to modify those functions. There is no change in functionality, but I want people to be able to see the changes I am making to functions in ctrlplot.py in the upcoming PR => need to move things around first so that git diff can highlight the changes.

Summary of changes:

  • The rcParams dict used to customize plotting functions is now in ctrlplot.py (instead of having two separate but identical rcParams in freqplot.py and timpelot.py).
  • The _process_ax_keyword utility function is now in ctrlplot.py (instead of freqplot.py).
  • The _process_line_labels utility function is now in ctrlplot.py (instead of freqplot.py).
  • The _get_line_labels utility function is now in ctrlplot.py (instead of freqplot.py).
  • The _add_arrows_to_line2D utility function is now in ctrlplot.py (instead of freqplot.py).
  • Rearranged some functions in grid.py.

@coveralls
Copy link

coveralls commented Jul 21, 2024

Coverage Status

coverage: 94.629%. remained the same
when pulling 009b821 on murrayrm:ctrlplot_refactor-27Jun2024
into da64e0e on python-control:main.

@@ -89,6 +112,125 @@ def get_plot_axes(line_array):
#
# Utility functions
#
# These functions are used by plotting routines to provide a consistent way
# of processing and displaing information.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# of processing and displaing information.
# of processing and displaying information.

@murrayrm murrayrm merged commit 1a276dc into python-control:main Jul 21, 2024
12 checks passed
@murrayrm murrayrm deleted the ctrlplot_refactor-27Jun2024 branch July 21, 2024 16:45
Copy link
Contributor

@sawyerbfuller sawyerbfuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@murrayrm murrayrm added this to the 0.10.1 milestone Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants