Skip to content

Control plot refactoring for consistent functionality #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Aug 9, 2024
Merged

Control plot refactoring for consistent functionality #1034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
5f6833f
speed up suptitle centering
murrayrm Jun 28, 2024
ca61be3
implement ControlPlot class for plotting return type
murrayrm Jun 27, 2024
639ffb4
add storage of legend objects
murrayrm Jun 29, 2024
acfadf0
fix bugs in legend generation for pole/zero plots
murrayrm Jul 3, 2024
8b7d399
improve consistency in use of cplt as return type for plots
murrayrm Jul 4, 2024
fb5c194
add unit tests for common plotting functionality
murrayrm Jul 4, 2024
97a5230
update phaseplot to use common ax, rcParams processing
murrayrm Jul 6, 2024
da5be15
TRV: fix legend size in Nyquist plots
murrayrm Jul 6, 2024
f818034
Fix suptitle for root locus plots
murrayrm Jul 6, 2024
0103fe7
update root_locus_plot to use common ax processing
murrayrm Jul 6, 2024
4f3d618
implement pole_zero_subplots
murrayrm Jul 6, 2024
0dc4790
update unit test for ax_processing
murrayrm Jul 14, 2024
cec9e70
update label processing to provide common functionality + unit tests
murrayrm Jul 15, 2024
89cda3d
update title processing to be uniform across _plot functions
murrayrm Jul 17, 2024
3a8fa7a
update plot title handling and make uniform
murrayrm Jul 18, 2024
8abb618
turn off title update if ax is given
murrayrm Jul 20, 2024
fc09a85
deprecate relabel keyword in time_response_plot
murrayrm Jul 20, 2024
4fe5f53
implement uniform legend processing + unit test/doc updates
murrayrm Jul 20, 2024
2e4961c
change suptitle_frame to title_frame
murrayrm Jul 20, 2024
02f2724
update rcParams processing
murrayrm Jul 21, 2024
4f4746d
deprecate get_plot_axes (with legacy testing)
murrayrm Jul 21, 2024
c3707d3
update plotting documentation
murrayrm Jul 21, 2024
4ec3612
add unit tests + docuementation for subplots
murrayrm Jul 21, 2024
e2f971b
small updates to increase code coverage
murrayrm Jul 21, 2024
d6df4be
update unit tests and documentation for line properties
murrayrm Jul 22, 2024
351bafe
unify color processesing
murrayrm Jul 26, 2024
36d1aef
fix small typos
murrayrm Jul 27, 2024
6b78134
fix color error introduced in phaseplot/separatrices
murrayrm Jul 27, 2024
d66064d
fix inconsistency in title for Nyquist plots
murrayrm Jul 27, 2024
9739750
small documentation updates (+ ruff configuration)
murrayrm Aug 4, 2024
9c6ff85
add gangof4_plot back as non-legacy function
murrayrm Aug 4, 2024
cd8fcfd
address review comments from @slivingston
murrayrm Aug 8, 2024
9f143ec
update freqplot unit test to avoid intermittent warnings
murrayrm Aug 8, 2024
1a04541
allow title to be None in _update_plot_title (fixes markov.py crash)
murrayrm Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions control/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

import collections
import warnings

from .exception import ControlArgument

__all__ = ['defaults', 'set_defaults', 'reset_defaults',
Expand Down Expand Up @@ -121,6 +122,10 @@ def reset_defaults():
# System level defaults
defaults.update(_control_defaults)

from .ctrlplot import _ctrlplot_defaults, reset_rcParams
reset_rcParams()
defaults.update(_ctrlplot_defaults)

from .freqplot import _freqplot_defaults, _nyquist_defaults
defaults.update(_freqplot_defaults)
defaults.update(_nyquist_defaults)
Expand Down
Loading
Loading