Skip to content

Small user documentation fixes #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 17, 2024
Merged

Conversation

murrayrm
Copy link
Member

This PR fixes a few small glitches in the user documentation:

  • The deprecated box_grid function was being included instead of boxgrid.
  • References to the phaseplot module were omitting the required phaseplot prefix, so that it might look like the could be called as ct.function (instead of ct.phaseplot.function or pp.function if you have imported control.phaseplot as pp).
  • There was an incorrect reference in the optimization-based control module than I found and fixed along the way.

This doesn't really need review. I'll leave it here for a few hours just in case someone wants to have a look, but I'll merge it in when I work on the 0.10.1 release starting later tonight (PDT) or tomorrow.

@coveralls
Copy link

coveralls commented Aug 17, 2024

Coverage Status

coverage: 94.694%. remained the same
when pulling d176201 on murrayrm:docfix-16Aug2024
into f86ebda on python-control:main.

@slivingston
Copy link
Member

I tried building the documentation with the Sphinx nitpicky option, and there are more broken links. I will open a PR tonight or tomorrow.

@slivingston
Copy link
Member

I will open a PR tonight or tomorrow.

Not enough to motivate another PR yet, so to avoid delaying the release, I include the diffs below in case you want to add them to this PR.

diff --git a/doc/plotting.rst b/doc/plotting.rst
index a4611f1..7d8d442 100644
--- a/doc/plotting.rst
+++ b/doc/plotting.rst
@@ -214,7 +216,7 @@ plot, use `plot_type='nichols'`::
 .. image:: freqplot-siso_nichols-default.png
 
 Another response function that can be used to generate Bode plots is
-the :func:`~control.gangof4` function, which computes the four primary
+the :func:`~control.gangof4_response` function, which computes the four primary
 sensitivity functions for a feedback control system in standard form::
 
   proc = ct.tf([1], [1, 1, 1], name="process")
diff --git a/doc/iosys.rst b/doc/iosys.rst
index eb4311e..ec0a528 100644
--- a/doc/iosys.rst
+++ b/doc/iosys.rst
@@ -25,7 +25,7 @@ a :class:`~control.StateSpace` linear system.  Use the
   ss_sys = ct.linearize(io_sys, xeq, ueq)
 
 Input/output systems are automatically created for state space LTI systems
-when using the :func:`ss` function.  Nonlinear input/output systems can be
+when using the :func:`~control.ss` function.  Nonlinear input/output systems can be
 created using the :func:`~control.nlsys` function, which requires
 the definition of an update function (for the right hand side of the
 differential or different equation) and an output function (computes the
@@ -435,7 +435,7 @@ of an individual system are used in a given specification::
   )
 
 And finally, since we have named the signals throughout the system in
-a consistent way, we could let :func:`ct.interconnect` do all of the
+a consistent way, we could let :func:`~control.interconnect` do all of the
 work::
 
   clsys5 = ct.interconnect(

@murrayrm murrayrm merged commit 6d42088 into python-control:main Aug 17, 2024
12 checks passed
@murrayrm murrayrm deleted the docfix-16Aug2024 branch August 17, 2024 12:34
@murrayrm murrayrm added this to the 0.10.1 milestone Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants