UnSkipTest: these tests pass on Python 2.7, 3.3, 3.4, and 3.5. #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does anyone know why these were being skipped originally? The |
|
Otherwise, I agree with the changes and will merge after some comment about the original motivation is made. Perhaps @jgoppert knows. |
|
I took a quick look and couldn't see any reason why these were skipped. |
slivingston
added a commit
that referenced
this pull request
Aug 14, 2016
title: "UnSkipTest: these tests pass on Python 2.7, 3.3, 3.4, and 3.5" #105
|
Before merging this, I found that all tests pass on a Debian GNU/Linux x86_64 box with Python versions 2.7.9, 3.3.6, 3.4.2, 3.5.2 |
|
Decided not to track this against milestone 0.8.0 since it is primarily an internal change (so not visible to users). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.